-
Couldn't load subscription status.
- Fork 35
Remove cross compile patch for Unix systems #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cross compile patch for Unix systems #583
Conversation
|
I will update the documentation once I see the ci pass. This is the method I use when avoiding the cross compile patch locally. Not sure every option added to the emscripten configure (emcmake part) is needed. I just took them from this Github issue in llvm llvm/llvm-project#60784 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 76.36% 76.36%
=======================================
Files 9 9
Lines 3655 3655
=======================================
Hits 2791 2791
Misses 864 864 🚀 New features to boost your workflow:
|
8124896 to
8b6933d
Compare
|
Hi, I think this is good but as the llvm build is at the heart of everything, I'll quickly verify this build locally and get back ! |
|
Hey @kr-2003, could you please help me verify this as I'm short on time. References
Serge and I discussed 2 approaches, we went for approach 1 back then but it seems approach 2 is what Matthew is trying and we need to verify it.
Verify and let me know if this is good to go ! Once sure of what needs to be done, please update the same changes on emscripten-forge's llvm recipe ! |
|
If this passes the ci we are good right? |
Hopefully but as Matthew writes "Not sure every option added to the emscripten configure (emcmake part) is needed" let's make sure one of us can have a clean build too ! |
|
Hi, I am a bit confused here @mcbarton Was looking into this, but I think the llvm build is being restored through cache isn't it ? Where can I come across the fresh one involving the changes above ? |
|
@anutosh491 I cleared the emscripten builds from the cache before creating this PR. You can see this PR create its cache builds here https://github.com/compiler-research/CppInterOp/actions/runs/15141592541 . The reason the cache builds for this PR no longer exists, is because I deleted them after the ci passed for the latest commit |
.github/workflows/emscripten.yml
Outdated
| -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER \ | ||
| -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY \ | ||
| -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY \ | ||
| -DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ONLY \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Have been looking into this. I don't think we should technically need any cmake_XX_YY command here. It's only the *-tblgen executable dirs we need to provide, hence I think only having DLLVM_NATIVE_TOOL_DIR should do the job isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should be good to go apart from this. Maybe try removing these flags and building ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using only LLVM_NATIVE_TOOL_DIR worked locally for me. I have cleared the cache of Emscripten builds, squashed the commits. Once the ci passes we should be good to merge, once the cache builds for this branch have been deleted (you can leave this to me if you would like).
One thing to note is that we still seem to build some native stuff as part of the Emscripten build even with this patch removed. If you look at the build you'll see the following Native directory still being built in the Emscripten build part
lib/DebugInfo/PDB/CMakeFiles/LLVMDebugInfoPDB.dir/Native/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh I think that might just be a side effect of some flag being on by default
once the cache builds for this branch have been deleted (you can leave this to me if you would like).
Cool, i'll just have a look once done, approve and you can take over then
973d977 to
5424013
Compare
5424013 to
9c54f99
Compare
|
@anutosh491 can you approve this PR now please? I'm hoping to merge this and the cling 1.2 support PR in tonight when things are quiet, since both are likely to have a disruptive effect while the cache rebuilds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me
Thank you
Description
Please include a summary of changes, motivation and context for this PR.
This PR will remove the need for the cross compile patch when doing an Emscripten build of llvm.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist